openshift / route-monitor-operator

Operator for monitoring liveness of Routes and URL's on OpenShift
Apache License 2.0
24 stars 53 forks source link

Update hypershift dependency to remove replace statements #286

Closed mjlshen closed 5 months ago

mjlshen commented 6 months ago

Leverage github.com/openshift/hypershift/api so that we can remove the replace statements that have been carried in go.mod. This will allow us to stop having to pin to old versions of libraries and more easily update dependencies moving forward, namely controller-runtime and K8s!

OSD-22069

mjlshen commented 6 months ago

/retest

mjlshen commented 6 months ago

/retest

wanghaoran1988 commented 6 months ago

integration tests failed :)

openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD d580c8eca4345ddf90b7ab211eaf2265048e46e3 and 2 for PR HEAD 7669e8adb04b28ec8319d7cf659f9d8eabf4d51c in total

mjlshen commented 6 months ago

I don't know why the integration test is failing yet, but when I figure out, I'll take the PR out of WIP

openshift-ci[bot] commented 5 months ago

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mjlshen commented 5 months ago

Finally figured out the integration test fix

cc @wanghaoran1988 @tnierman

dustman9000 commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/route-monitor-operator/blob/master/OWNERS)~~ [dustman9000,mjlshen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment