Closed mjlshen closed 5 months ago
/retest
/retest
integration tests failed :)
/retest-required
Remaining retests: 0 against base HEAD d580c8eca4345ddf90b7ab211eaf2265048e46e3 and 2 for PR HEAD 7669e8adb04b28ec8319d7cf659f9d8eabf4d51c in total
I don't know why the integration test is failing yet, but when I figure out, I'll take the PR out of WIP
@mjlshen: all tests passed!
Full PR test history. Your PR dashboard.
Finally figured out the integration test fix
cc @wanghaoran1988 @tnierman
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dustman9000, mjlshen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Leverage
github.com/openshift/hypershift/api
so that we can remove thereplace
statements that have been carried in go.mod. This will allow us to stop having to pin to old versions of libraries and more easily update dependencies moving forward, namely controller-runtime and K8s!OSD-22069