search

openshift / route-monitor-operator

Operator for monitoring liveness of Routes and URL's on OpenShift
Apache License 2.0
24 stars 53 forks source link

[OSD-23845] Add cache whitelist #327

Open zmird-r opened 6 days ago

zmird-r commented 6 days ago

Adds a list of resources to cache.

Ticket: https://issues.redhat.com/browse/OSD-23845

Nikokolas3270 commented 5 days ago

PR looks fine to me. I wonder however if it could be possible to limit the memory taken by the cache rather than filtering out the objects to cache. Proper cache management involves a proper cleanup policy. Here, from what I understood, once an object enters in the cache, it stays there forever; that's not proper cache management & that's a problem. I will take a look at the other cache options and let you know. But for now, let's merge this PR

Nikokolas3270 commented 5 days ago

/lgtm

zmird-r commented 5 days ago

/approve

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nikokolas3270, zmird-r Once this PR has been reviewed and has the lgtm label, please assign dustman9000 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/route-monitor-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 day ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 1 day ago

@zmird-r: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).