[release-4.15] OCPBUGS-32693: Reject routes with MD5 certs

[openshift-cherrypick-robot]

This is an automated cherry-pick of #553

/assign gcs278

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26539 has been cloned as Jira Issue OCPBUGS-32693. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-32693: Reject routes with MD5 certs

In response to [this](https://github.com/openshift/router/pull/584): >This is an automated cherry-pick of #553 > >/assign gcs278 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32693, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/router/pull/584): >This is an automated cherry-pick of #553 > >/assign gcs278 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[Miciah]

Quoting Grant:

it's low risk as the HaProxy currently fails to start when it tries to process a spec.tls.certificate with an MD5 cert (same type of issues as SHA1 in 4.16).

Moreover, the change is a small change, well isolated in the extended validation logic, and conditioned on certificates that use the MD5 signature algorithm. All in all, I agree that this backport is low risk.

/label backport-risk-assessed

[Miciah]

/approve /lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/router/blob/release-4.15/OWNERS)~~ [Miciah] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[gcs278]

/refresh jira

[gcs278]

/jira refresh

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-32693, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-26539](https://issues.redhat.com//browse/OCPBUGS-26539) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-26539](https://issues.redhat.com//browse/OCPBUGS-26539) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/router/pull/584#issuecomment-2071337290): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[gcs278]

OVNKubernetesResourceRetryFailure. Doesn't appear related. /test e2e-aws-serial

[openshift-ci[bot]]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[ShudiLi]

/label cherry-pick-approved thanks

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-32693: All pull requests linked via external trackers have merged:

• openshift/router#584

Jira Issue OCPBUGS-32693 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/router/pull/584): >This is an automated cherry-pick of #553 > >/assign gcs278 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-haproxy-router-base-container-v4.15.0-202405060208.p0.g1cac6b7.assembly.stream.el8 for distgit ose-haproxy-router-base. All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-05-06-031252