openshift-ci-robot
commented
4 months ago @gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid.
3 validation(s) were run on this bug
* bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)Requesting review from QA contact: /cc @ShudiLi
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/router/pull/587):
>Previously, both performIngressConditionUpdate and performIngressConditionRemoval functions were adding tasks to the writerlease queue even if no work needed to be done. This commit optimizes the logic by ensuring that tasks are only added to the queue when changes are required.
>
>This reduction in unnecessary work significantly lowers the frequency of lease extensions. Previously, excessive lease extensions could delay route status updates under certain conditions, such as during temporary contention periods
>where a router pod gets demoted to a follower. After the contention is resolved, the pod’s subsequent retry will be delayed more than necessary.
>
>Additionally, this update provides a clearer indication of when updates are actually required, but have been completed by another router pod. The prior logic did not clearly distinguish between unnecessary updates and updates that were completed by another pod.
>
>This PR also add some logging in leasewriter and the plugin chain for assisting future debugging efforts.
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
gcs278
openshift-ci[bot]
Miciah
openshift-bot
Both performIngressConditionUpdate and performIngressConditionRemoval functions add tasks to the writerlease queue even if no work needed to be done. This commit optimizes the Upgrade Validation plugin by ensuring that tasks for updating UnservableInFutureVersions are only added to the queue when changes are required.
This reduction in unnecessary work significantly lowers the frequency of lease extensions. Previously, excessive lease extensions could delay route status updates under certain conditions, such as during temporary contention periods where a router pod gets demoted to a follower. After the contention is resolved, the pod’s subsequent retry will be delayed more than necessary.
Additionally, this update provides a clearer indication of when updates are actually required, but have been completed by another router pod. The prior logic did not clearly distinguish between unnecessary updates and updates that were completed by another pod.
The selective updates are only added to the interface used by Upgrade Validation plugin to avoid perturbing existing Admitted condition logic. This means nominal clusters without SHA1 routes should not be impacted by the Upgrade Validation plugin, minimizing the risk associated with its introduction.
Fixes TestRouteAdmissionPolicy Flake by reducing the number of unnecessary lease extensions.