search

openshift / router

Ingress controller for OpenShift
Apache License 2.0
68 stars 114 forks source link

WIP: NE-906: test dynamic config manager #603

Closed frobware closed 3 months ago

frobware commented 3 months ago
openshift-ci-robot commented 3 months ago

@frobware: This pull request references NE-906 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/router/pull/603): >- reload-haproxy: Track changes with diff and snapshots >- pkg/router/metrics/health: log success at level 5 >- Add obvious reload indicator in commitAndReload function >- hack/Makefile.debug: record the image ref for debugging [NE-906](https://issues.redhat.com//browse/NE-906) >- Modify router shutdown delay for debugging >- hack/Dockerfile.debug: set openshift-router log level to 2 >- pkg/router/template/configmanager/haproxy/backend: log.V(4) => log.V(2) >- Disable blueprint routes > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@frobware: This pull request references NE-906 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/router/pull/603): >- reload-haproxy: Track changes with diff and snapshots >- pkg/router/metrics/health: log success at level 5 >- Add obvious reload indicator in commitAndReload function >- hack/Makefile.debug: record the image ref for debugging [NE-906](https://issues.redhat.com//browse/NE-906) >- Modify router shutdown delay for debugging >- hack/Dockerfile.debug: set openshift-router log level to 2 >- pkg/router/template/configmanager/haproxy/backend: log.V(4) => log.V(2) >- Disable blueprint routes > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from frobware. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/router/blob/release-4.16/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment