search

openshift / router

Ingress controller for OpenShift
Apache License 2.0
68 stars 114 forks source link

OCPBUGS-36630: Add hack Makefile target to build CI version of router image #612

Open alebedev87 opened 2 months ago

alebedev87 commented 2 months ago

This PR enables the build of the CI version router image on local. The same base and router dockerfiles are used by the new target. Use case: I want the same image that the CI would build but with my fix.

openshift-ci-robot commented 2 months ago

@alebedev87: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/router/pull/612): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from alebedev87. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/router/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/router/pull/612): >This PR enables the build of the CI version router image on local. The same [base and router dockerfiles are used](https://github.com/openshift/release/blob/d27dd22029dc85e2d58327cc8ad88d6eaf33f44e/ci-operator/config/openshift/router/openshift-router-master.yaml#L16-L29) by the new target. Use case: I want the same image that the CI would build but with my fix. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ShudiLi commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@ShudiLi: This pull request references Jira Issue OCPBUGS-36630, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @ShudiLi

In response to [this](https://github.com/openshift/router/pull/612#issuecomment-2219607465): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rfredette commented 1 month ago

/assign

grzpiotrowski commented 4 weeks ago

Since this touches the hacks, I wanted to throw in a little change to propose alongside. Please ignore if this shouldn't be included here.

In HACKING.md: lines 28-29 describe theDockerfile.debug file and state that:

(...) The outputted image uses `centos:8` as it's base
since installing packages on an OpenShift RHEL base image requires RHEL entitlements.

but ubi9 is actually used as the base image there instead. This mention of centos:8 could be deleted then?

alebedev87 commented 6 days ago

/retest

ShudiLi commented 6 days ago

/label qe-approved thanks

openshift-ci-robot commented 6 days ago

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/router/pull/612): >This PR enables the build of the CI version router image on local. The same [base and router dockerfiles are used](https://github.com/openshift/release/blob/d27dd22029dc85e2d58327cc8ad88d6eaf33f44e/ci-operator/config/openshift/router/openshift-router-master.yaml#L16-L29) by the new target. Use case: I want the same image that the CI would build but with my fix. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
alebedev87 commented 6 days ago

/jira refresh

openshift-ci-robot commented 6 days ago

@alebedev87: This pull request references Jira Issue OCPBUGS-36630, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @ShudiLi

In response to [this](https://github.com/openshift/router/pull/612#issuecomment-2343518000): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 days ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).