search

openshift / router

Ingress controller for OpenShift
Apache License 2.0
74 stars 116 forks source link

[RFE-5098] Support for customizing HAProxy error code response page for http error code 504 #628

Open natlibfi-jonollil opened 1 month ago

natlibfi-jonollil commented 1 month ago

I'm not sure if this is enough to make this work. Or should this be against master or next release version?

We have noticed problems regarding error response descriptions with HA-proxy. Problems have been encountered during timeouts and whitelisting as in these cases request produces blank response and this makes debugging work difficult. After finding out the reasons for the problems, we propose adding status codes 504 and 403 to the error responses to help identifying problems with timeouts and access rights in the future.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/router/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

Hi @natlibfi-jonollil. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.