openshift / router

Ingress controller for OpenShift
Apache License 2.0
74 stars 116 forks source link

OCPBUGS-26603: Listen for stats connections on v6 addresses when relevant. #633

Closed rfredette closed 3 weeks ago

rfredette commented 4 weeks ago

When the router is configured for ipv6 or dual stack modes, it already listens on ipv6 ports for normal traffic. This change makes the router listen on ipv6 ports for stats traffic as well.

This is part of the fix for OCPBUGS-26603.

openshift-ci-robot commented 4 weeks ago

@rfredette: This pull request references Jira Issue OCPBUGS-26603, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/router/pull/633): >When the router is configured for ipv6 or dual stack modes, it already listens on ipv6 ports for normal traffic. This change makes the router listen on ipv6 ports for stats traffic as well. > >This is part of the fix for OCPBUGS-26603. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Miciah commented 4 weeks ago

/approve /lgtm /hold in case you want a second reviewer.

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/router/blob/master/OWNERS)~~ [Miciah] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 weeks ago

@rfredette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 9bc585669fb1f8e379b7fbd7cc04607d3ce1e0ba link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rfredette commented 3 weeks ago

/retest

candita commented 3 weeks ago

/assign @alebedev87

rfredette commented 3 weeks ago

Will we plan to fix this in origin tests too?

The origin tests do need some fixes for ipv6 support, which is going to be part of this bug fix, but I think changing them to use managed router pods is out of the scope of this issue. I'm not sure what the reason is for using unmanaged pods; maybe it's because they're older tests from when unmanaged router pods were something we supported, but it could also be an intentional choice that I don't yet understand. I'll create a task to look into that, though.

rfredette commented 3 weeks ago

origin test changes here: https://github.com/openshift/origin/pull/29224

alebedev87 commented 3 weeks ago

LGTM /unhold

rfredette commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@rfredette: This pull request references Jira Issue OCPBUGS-26603, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @ShudiLi

In response to [this](https://github.com/openshift/router/pull/633#issuecomment-2433017962): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@rfredette: Jira Issue OCPBUGS-26603: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-26603 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/router/pull/633): >When the router is configured for ipv6 or dual stack modes, it already listens on ipv6 ports for normal traffic. This change makes the router listen on ipv6 ports for stats traffic as well. > >This is part of the fix for OCPBUGS-26603. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Frouter). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-haproxy-router-base This PR has been included in build ose-haproxy-router-base-container-v4.18.0-202410232040.p0.gef8db0a.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-haproxy-router This PR has been included in build openshift-enterprise-haproxy-router-container-v4.18.0-202410232040.p0.gef8db0a.assembly.stream.el9. All builds following this will include this PR.