openshift / sandboxed-containers-operator

An operator to enhance an Openshift/Kubernetes cluster to support running sandboxed containers
Apache License 2.0
37 stars 41 forks source link

Adds script to auto create libvirt podvm config - #435 #436

Open Saripalli-lavanya opened 3 months ago

Saripalli-lavanya commented 3 months ago

- Description of the problem which is fixed/What is the use case Added script to Automatically create libvirt pool and volume on KVM host and upon successful creation same script will create peer-pod secret, config map & ssh secret. - #435 - What I did

- How to verify it

- Description for the changelog

openshift-ci[bot] commented 3 months ago

Hi @Saripalli-lavanya. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
savitrilh commented 3 months ago

@Saripalli-lavanya Add the script to cleanup when kataconfig is unconfigured

gkurz commented 3 months ago

Hi @Saripalli-lavanya and @savitrilh ! Thanks for all the huge work you are doing :smile:

I'll just suggest that you break down the first commit into smaller logical and bisectable pieces. Even if this might look like extra work, it is largely beneficial for everyone :

Also, we don't have pre-merge CI currently : bugs will be found late. Being able to bisect can really make a difference for non-obvious ones.

Cheers !