search

openshift / sdn

Apache License 2.0
87 stars 92 forks source link

openshift-sdn does not allow to configure a custom mac #15

Closed alonSadan closed 3 years ago

alonSadan commented 5 years ago

openshift-sdn does not allow to configure a custom mac.

I am copying here @booxter thorough explanation for the similar issue on ovn-kubernetes:

OK, let me expand because it sounds like perhaps Alon asked the project to come up with its own solution for hardware addresses, while in reality there is prior art in CNI plugins for the same.

The Network Plumbing working group of Kubernetes came up with a standard for network attachment definitions: https://docs.google.com/document/d/1Ny03h6IDVy_e_vmElOqR7UdTPAG_RNydhVE1Kx54kFQ/edit

This document explains how additional networks can be attached to pods and is implemented by Multus CNI plugin. This document defines, among other things, the mac attribute that can be passed via CNI_ARGS into the plugin. If it's passed, then the plugin is supposed to enforce it for the prepared binding. This feature is already implemented in multiple CNI plugins (e.g. ovs-cni, sriov-cni), it can also be implemented not natively via tuning plugin chaining. Other projects like KubeVirt / kubemacpool rely on this attribute for some features to work.

It would be very helpful if OVN-Kubernetes plugin adds support for this attribute like other plugins did, so that we can use it in KubeVirt / kubemacpool environments.

Thank you for consideration.

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/sdn/issues/15#issuecomment-726596734): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.