search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

add simple config merging #10

Closed deads2k closed 6 years ago

deads2k commented 6 years ago

Adds simple config merging based on bare maps with list of special-case functions for particular keys (and their descendants. I think it's the simplest possible thing that works while preserving the ability to handle things like like our admission config.

@mfojtik @sttts @liggitt

sttts commented 6 years ago

Am worried to merge this without some integration test coverage of the operator.

deads2k commented 6 years ago

Am worried to merge this without some integration test coverage of the operator.

https://github.com/openshift/service-serving-cert-signer/issues/8 is still outstanding. There's no obvious end in sight. We will eventually end up with this in cluster up (maybe even this release) and there are unit tests already.