search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

[WIP] Add ConfigMap injection controller #20

Closed mrogers950 closed 6 years ago

mrogers950 commented 6 years ago

This adds a controller managed by the operator that injects the service CA bundle into configmaps that are annotated with service.alpha.openshift.io/inject-cabundle: true. The current state of the PR is that the operator starts the controller and it runs, but I have yet to get it to properly update a configmap, so there is something off at the moment. But I would like to go ahead and get some eyes on it. @openshift/sig-security

mrogers950 commented 6 years ago

Now adding some controller tests and fixing the logic when deleting both the configMap CAbundle and annotation (when doing so another update gets queued and the CAbundle is added back)

mrogers950 commented 6 years ago

All set. @openshift/sig-security @deads2k PTAL.

mrogers950 commented 6 years ago

@stlaz Thanks, I addressed your comments.

mrogers950 commented 6 years ago

@ericavonb updated, PTAL

mrogers950 commented 6 years ago

/retest

mrogers950 commented 6 years ago

@ericavonb updated.

openshift-ci-robot commented 6 years ago

@mrogers950: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 10bef20ce3b1cb4b0325bbeaafbbb8e1670e4315 link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ericavonb commented 6 years ago

/lgtm

mrogers950 commented 6 years ago

Added WIP back to make sure we don't merge into the service-serving-cert-signer image. We'll merge it in the new repo.

mrogers950 commented 6 years ago

Closing since this feature merged in https://github.com/openshift/service-ca-operator