search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

adjust manifests #28

Closed mrogers950 closed 6 years ago

mrogers950 commented 6 years ago

Dropped the 01_serviceservingcertsigner prefix, per @smarterclayton advice. I also updated the image references to include the repo name and to match the tag and container name. I don't know if this is explicitly required, but it aligns with the other examples that I looked at. /cc @openshift/sig-security @juanvallejo

mrogers950 commented 6 years ago

@smarterclayton thanks, updated.

mrogers950 commented 6 years ago

I've done the same update for the service-ca repo: https://github.com/openshift/service-ca-operator/pull/9

abhinavdahiya commented 6 years ago

Also seems like service account is next in order to deployment, The deployment will not complete rollout with out existing service account and ClusterVersionOperator waits for rollout to complete for a deployment as its done criteria. Do you mind changing the order to serviceaccount then deployment.

mrogers950 commented 6 years ago

@abhinavdahiya done

mrogers950 commented 6 years ago

@smarterclayton @abhinavdahiya are the manifest filenames here still correct or do I need to prepend a 0000_01 to them? I noticed this might have changed per your comment at https://github.com/openshift/cluster-openshift-apiserver-operator/pull/15#issuecomment-425481195

smarterclayton commented 6 years ago

Do any components depend on you being installed before they are installed? That is the only reason you would be allowed to use the run level notation.

juanvallejo commented 6 years ago

@smarterclayton

Do any components depend on you being installed before they are installed? That is the only reason you would be allowed to use the run level notation.

I believe that the openshift-apiserver would depend on this operator. cc @deads2k

smarterclayton commented 6 years ago

/lgtm