search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

Rate limit sync attempts #37

Closed mrogers950 closed 5 years ago

mrogers950 commented 5 years ago

Rate limit the sync loop similar to cluster-kube-controller-manager-operator. This should help cut down on the amount of API requests. /cc @deads2k @juanvallejo @openshift/sig-security

openshift-ci-robot commented 5 years ago

@mrogers950: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 97b1398df9bff54bee482e62547192ad3098dac9 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
enj commented 5 years ago

Rate limiting should be handled via the queue.

mrogers950 commented 5 years ago

Rate limiting should be handled via the queue.

@deads2k what's the reason the other operators handle this through a separate limit as opposed to tweaking the workqueue?

openshift-bot commented 5 years ago

@mrogers950: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrogers950 commented 5 years ago

obsoleted