search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

Fix the service controller secretHasSynced function #40

Closed mrogers950 closed 5 years ago

mrogers950 commented 5 years ago

@openshift/sig-auth

mrogers950 commented 5 years ago

Can we add tests (ideally unit but I know that isn't easy) that would have caught this?

Looking at WaitForCacheSync there's no verification that the sync functions are distinct so I'm not sure what we would test for exactly.

enj commented 5 years ago

/close

Handled in #52

I do not think there is a good way for us to compare functions (and you could still simply forget to supply one).

Please open a PR against github.com/openshift/service-serving-cert-signer/pkg/boilerplate/controller if you think there is a simple and effective solution.

openshift-ci-robot commented 5 years ago

@enj: Closing this PR.

In response to [this](https://github.com/openshift/service-serving-cert-signer/pull/40#issuecomment-438796396): >/close > >Handled in #52 > >I do not think there is a good way for us to compare functions (and you could still simply forget to supply one). > >Please open a PR against `github.com/openshift/service-serving-cert-signer/pkg/boilerplate/controller` if you think there is a simple and effective solution. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.