Allow update of existing secrets with new certs

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator

Apache License 2.0

13 stars 18 forks source link

Allow update of existing secrets with new certs #49

Closed mrogers950 closed 5 years ago

mrogers950 commented 5 years ago

For rotation purposes we have to be able to update an existing secret with new certificate data. @openshift/sig-auth

mrogers950 commented 5 years ago

@enj I think that we discussed that this is not the job of the secret creating controller, but the secret update controller (which will need an addition of a regeneration check when the CA cn changes.), so we might close this in lieu of a different PR.

openshift-bot commented 5 years ago

@mrogers950: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.