openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

Filter operator informer events #54

Closed mrogers950 closed 5 years ago

mrogers950 commented 5 years ago

Only queue up on the resources that we care about, rather than everything. @openshift/sig-auth

sjenning commented 5 years ago

wrt apiserver request rates, seems to still be high

{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"} | 10.333333333333334
{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"} | 4

however, with the broken out clients, we can tell which is which now :+1:

sort_desc(sum by (verb) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"}[1m])))

{verb="GET"} | 8.666666666666666
{verb="PUT"} | 1
{verb="UPDATE"} | 0.6666666666666666
{verb="WATCH"} | 0.03333333333333333

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="GET"}[1m])))

{namespace="default",resource="configmaps"} | 1.6666666666666667
{namespace="default",resource="namespaces"} | 1
{namespace="default",resource="clusterrolebindings"} | 1
{namespace="default",resource="clusterroles"} | 1
{namespace="default",resource="services"} | 1
{namespace="default",resource="deployments"} | 1
{namespace="default",resource="serviceaccounts"} | 1
{namespace="default",resource="secrets"} | 0.3333333333333333
{namespace="default",resource="servicecertsigneroperatorconfigs"} | 0.3333333333333333
{namespace="default",resource="clusteroperators"} | 0.3333333333333333

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="openshift-service-cert-signer-operator service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="PUT"}[1m])))

{namespace="default",resource="clusterrolebindings"} | 1.0000000000000002
sort_desc(sum by (verb) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format"}[1m])))

{verb="GET"} | 2
{verb="PUT"} | 2

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="GET"}[1m])))

{namespace="default",resource="configmaps"} | 2

sort_desc(sum by (resource, namespace) (rate(apiserver_request_count{client="service-serving-cert-signer/v0.0.0 (linux/amd64) kubernetes/$Format",verb="PUT"}[1m])))

{namespace="default",resource="configmaps"} | 2
mrogers950 commented 5 years ago

@enj updated to use the new filter functions.

enj commented 5 years ago

/lgtm

Good start. We will tackle the status update and informer configuration next. Hopefully after those bits are nailed down, this operator will be nice and quiet.