search

openshift / service-serving-cert-signer

Archiving in favor of https://github.com/openshift/service-ca-operator
Apache License 2.0
13 stars 18 forks source link

add the controller command #7

Closed deads2k closed 6 years ago

deads2k commented 6 years ago

Add the command for the SSCS controller and updates the operator to make it work.

WIP in while I sort out the deps.

oc cluster up --kube-only
oc auth reconcile -f install/serving-cert-signer/install-rbac.yaml
oc create -f manifests/v3.10.0/service-serving-cert-signer-controller/clusterrole.yaml
oc create -f manifests/v3.10.0/service-serving-cert-signer-controller/clusterrolebinding.yaml
oc apply -f install/serving-cert-signer/install.yaml

The clusterrole and binding need to move into the operator, but I think that can be a post step.

deads2k commented 6 years ago

/assign @mfojtik

this is ready for review while I sort out the upstream

mfojtik commented 6 years ago

one nit, /lgtm after TODOs are addressed ;-)

deads2k commented 6 years ago

nits fixed, deps addressed. plan to merge on green and keep working from here.