openshift / source-to-image

A tool for building artifacts from source and injecting into container images
Apache License 2.0
2.47k stars 698 forks source link

pull policy "if-not-present" yet still querying remote registry #1134

Open jmtd opened 11 months ago

jmtd commented 11 months ago

This is a little odd. s2i build --pull-policy if-not-present appears to query a remote registry for (at least) metadata even if the named image is present in the local registry.

Log excerpt from https://github.com/jboss-container-images/openjdk/actions/runs/6864309836/job/19052020240 (the original logs are enormous):

DEBUG Executing 's2i build --loglevel=5 --pull-policy if-not-present  --context-dir=undertow-servlet -r=master  https://github.com/jboss-openshift/openshift-quickstarts ubi9/openjdk-21:1.17 integ-ubi9/openjdk-21:1.17  ' command...
ERROR I1127 11:44:13.305506   19494 build.go:52] Running S2I version "v1.3.4"
ERROR I1127 11:44:13.306519   19494 util.go:58] Getting docker credentials for ubi9/openjdk-21:1.17
ERROR I1127 11:44:13.306544   19494 util.go:74] Using  credentials for pulling ubi9/openjdk-21:1.17
ERROR W1127 11:44:13.518495   19494 build.go:167] could not inspect the builder image for labels: reading manifest 1.17 in docker.io/ubi9/openjdk-21: errors:
ERROR denied: requested access to the resource is denied
ERROR unauthorized: authentication required
ERROR I1127 11:44:13.520728   19494 docker.go:491] Using locally available image "docker.io/ubi9/openjdk-21:latest"

Note that the named builder image ubi9/openjdk-17 exists in the local docker container storage, and the rest the S2I process works as expected using the local image.

Confirmed with 1.3.4 and 1.3.9.

openshift-bot commented 8 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 7 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

jmtd commented 7 months ago

/remove-lifecycle rotten

openshift-bot commented 6 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 6 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/source-to-image/issues/1134#issuecomment-2080246815): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jmtd commented 6 months ago

/reopen

I guess the bot didn’t like my fresh command

openshift-ci[bot] commented 6 months ago

@jmtd: Reopened this issue.

In response to [this](https://github.com/openshift/source-to-image/issues/1134#issuecomment-2080410178): >/reopen > >I guess the bot didn’t like my fresh command Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 5 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 5 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/source-to-image/issues/1134#issuecomment-2134153716): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jmtd commented 5 months ago

/reopen /remove-lifecycle rotten /lifecycle frozen

openshift-ci[bot] commented 5 months ago

@jmtd: Reopened this issue.

In response to [this](https://github.com/openshift/source-to-image/issues/1134#issuecomment-2134468949): >/reopen >/remove-lifecycle rotten >/lifecycle frozen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.