search

openshift / source-to-image

A tool for building artifacts from source and injecting into container images
Apache License 2.0
2.46k stars 696 forks source link

chore: update docker to v25 #1140

Closed matejvasek closed 7 months ago

matejvasek commented 7 months ago

update docker to v25

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

matejvasek commented 7 months ago

/test all

matejvasek commented 7 months ago

/retest

matejvasek commented 7 months ago

/test all

matejvasek commented 7 months ago

/retest-required

matejvasek commented 7 months ago

/test security

matejvasek commented 7 months ago

/retest

matejvasek commented 7 months ago

/test all

matejvasek commented 7 months ago

@coreydaley

matejvasek commented 7 months ago

/cc @coreydaley

coreydaley commented 7 months ago

/assign @sayan-biswas @adambkaplan

matejvasek commented 7 months ago

@coreydaley is the security check failure really related to my PR?

coreydaley commented 7 months ago

@matejvasek No, and the security check is also option, so it will not stop the pull request from merging.

matejvasek commented 7 months ago

@coreydaley We need this to get rid off some CVE reports in RH jira. The CVEs do not really affects us but we do not want to see the warnings.

matejvasek commented 7 months ago

@adambkaplan wort case: I can use the old deprecated ctor and override linter error. EDIT: I cannot use old ctor. We need WithAPIVersionNegotiation().

matejvasek commented 7 months ago

PTAL @adambkaplan

adambkaplan commented 7 months ago

/assign @sayan-biswas

Feel free to use /approve to green-light merge - I can add the LGTM once the comment suggestion is added and commits are squashed.

@matejvasek - in your commit message please explain why we need API version negotiation for docker. This makes it easier for future maintainers to understand why the change was introduced, without having to chase down this pull request and unroll the comments.

openshift-ci[bot] commented 7 months ago

@matejvasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 30302e16d543b029ceb7ec70a45be18c079963fe link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sayan-biswas commented 7 months ago

/approve

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, matejvasek, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/source-to-image/blob/master/OWNERS)~~ [sayan-biswas] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment