openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-37668: [release-4.17]: Fix operator quick restart for SNO #1001

Closed zeeke closed 1 month ago

zeeke commented 2 months ago

4.17 Backport of:

openshift-ci-robot commented 2 months ago

@zeeke: This pull request references Jira Issue OCPBUGS-37668, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001): >4.17 Backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/760 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload f521b1e52bce044926c43f8ca7c31dc2e6952959 link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zeeke commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@zeeke: This pull request references Jira Issue OCPBUGS-37668, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-23795](https://issues.redhat.com//browse/OCPBUGS-23795) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-23795](https://issues.redhat.com//browse/OCPBUGS-23795) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001#issuecomment-2330960073): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 2 months ago

/test e2e-telco5g-sriov

zeeke commented 2 months ago

:green_circle: newly added test case passed on ci/prow/e2e-telco5g-sriov:

SRIOV Operator conformance tests: [It] [sriov] operator No SriovNetworkNodePolicy should gracefully restart quickly webhooks enabled    5s
SRIOV Operator conformance tests: [It] [sriov] operator No SriovNetworkNodePolicy should gracefully restart quickly webhooks disabled

@SchSeba @evgenLevin can you please take a look at this backport?

zeeke commented 1 month ago

@SchSeba, @wizhaoredhat can you take a look at this backport?

@evgenLevin, @ajaggapa, I need qe approval, too, when you have time (cherry-pick-approved)

ajaggapa commented 1 month ago

/cherry-pick-approved

zeeke commented 1 month ago

/cherry-pick-approved

did you mean /label cherry-pick-approved ? :slightly_smiling_face:

ajaggapa commented 1 month ago

/label cherry-pick-approved

SchSeba commented 1 month ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.17/OWNERS)~~ [SchSeba,zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ajaggapa commented 1 month ago

/label cherry-pick-approved

zeeke commented 1 month ago

/override ci/prow/e2e-openstack-nfv-hwoffload

job ci/prow/e2e-openstack-nfv-hwoffload has been removed from CI configuration

openshift-ci[bot] commented 1 month ago

@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-openstack-nfv-hwoffload

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001#issuecomment-2396745549): >/override ci/prow/e2e-openstack-nfv-hwoffload > >job `ci/prow/e2e-openstack-nfv-hwoffload` has been removed from CI configuration Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

@zeeke: Jira Issue OCPBUGS-37668: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37668 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001): >4.17 Backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/760 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 1 month ago

/jira backport release-4.16,release-4.15,release-4.14

openshift-ci-robot commented 1 month ago

@zeeke: Missing required branches for backport chain:

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001#issuecomment-2396779561): >/jira backport release-4.16,release-4.15,release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 1 month ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 1 month ago

@zeeke: new pull request created: #1011

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1001#issuecomment-2396781580): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.17.0-202410071236.p0.g40fc75e.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202410071236.p0.g40fc75e.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.17.0-202410071236.p0.g40fc75e.assembly.stream.el9. All builds following this will include this PR.