search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
117 stars 106 forks source link

OCPBUGS-42252: [release-4.17] Preserve user defined annotations on `SriovNetworks` #1008

Open zeeke opened 3 days ago

zeeke commented 3 days ago

4.17 backport of:

zeeke commented 3 days ago

/jira cherrypick OCPBUGS-41352

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.17/OWNERS)~~ [zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 days ago

@zeeke: Jira Issue OCPBUGS-41352 has been cloned as Jira Issue OCPBUGS-42252. Will retitle bug to link to clone. /retitle OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008#issuecomment-2363456962): >/jira cherrypick OCPBUGS-41352 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 days ago

@zeeke: This pull request references Jira Issue OCPBUGS-42252, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008): >4.17 backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/775 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 3 days ago

/test e2e-telco5g-sriov

openshift-ci[bot] commented 3 days ago

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).