search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-42252: [release-4.17] Preserve user defined annotations on `SriovNetworks` #1008

Closed zeeke closed 1 week ago

zeeke commented 2 months ago

4.17 backport of:

zeeke commented 2 months ago

/jira cherrypick OCPBUGS-41352

openshift-ci-robot commented 2 months ago

@zeeke: Jira Issue OCPBUGS-41352 has been cloned as Jira Issue OCPBUGS-42252. Will retitle bug to link to clone. /retitle OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008#issuecomment-2363456962): >/jira cherrypick OCPBUGS-41352 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@zeeke: This pull request references Jira Issue OCPBUGS-42252, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008): >4.17 backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/775 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 2 months ago

/test e2e-telco5g-sriov

SchSeba commented 1 month ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.17/OWNERS)~~ [SchSeba,zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ajaggapa commented 1 month ago

/label cherry-pick-approved

zeeke commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@zeeke: This pull request references Jira Issue OCPBUGS-42252, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-41352](https://issues.redhat.com//browse/OCPBUGS-41352) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-41352](https://issues.redhat.com//browse/OCPBUGS-41352) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008#issuecomment-2482781725): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@zeeke: Jira Issue OCPBUGS-42252: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42252 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1008): >4.17 backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/775 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.17.0-202411181337.p0.gf06fec3.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.17.0-202411181337.p0.gf06fec3.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202411181337.p0.gf06fec3.assembly.stream.el9. All builds following this will include this PR.