search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-43108: [release-4.17] Delete webhooks when SriovOperatorConfig is deleted #1017

Closed zeeke closed 2 weeks ago

zeeke commented 1 month ago

When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error:

Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found

as the webhook configuration is still present, while the Service and the DaemonSet has been deleted.

Delete all the webhook configurations when the user deletes the default SriovOperatorConfig

4.17 backport of

zeeke commented 1 month ago

/jira cherrypick OCPBUGS-41897

openshift-ci-robot commented 1 month ago

@zeeke: Jira Issue OCPBUGS-41897 has been cloned as Jira Issue OCPBUGS-43108. Will retitle bug to link to clone. /retitle OCPBUGS-43108: [release-4.17] Delete webhooks when SriovOperatorConfig is deleted

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017#issuecomment-2407772723): >/jira cherrypick OCPBUGS-41897 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@zeeke: This pull request references Jira Issue OCPBUGS-43108, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017): >When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error: >``` >Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found >``` > >as the webhook configuration is still present, while the Service and the DaemonSet has been deleted. > >Delete all the webhook configurations when the user deletes the default SriovOperatorConfig > >4.17 backport of >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/779 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 1 month ago

/test e2e-telco5g-sriov /retest

zeeke commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@zeeke: This pull request references Jira Issue OCPBUGS-43108, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-41897](https://issues.redhat.com//browse/OCPBUGS-41897) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-41897](https://issues.redhat.com//browse/OCPBUGS-41897) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @evgenLevin

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017#issuecomment-2416760161): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 1 month ago

@SchSeba, @wzheng1 please take a look

cc @thom311

thom311 commented 1 month ago

See also 4.16 issue OCPBUGS-37951.

lgtm.

wizhaoredhat commented 1 month ago

/lgtm

zeeke commented 1 month ago

Also added a small log optimization https://github.com/openshift/sriov-network-operator/pull/1017/commits/4734e36622f93da8212ee29e0eaafc2c10d04d6d

zeeke commented 1 month ago

/test e2e-telco5g-sriov

openshift-ci[bot] commented 1 month ago

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zeeke commented 2 weeks ago

@SchSeba @evgenLevin please take a look at this backport

evgenLevin commented 2 weeks ago

/lgtm /label cherry-pick-approved

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evgenLevin, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.17/OWNERS)~~ [wizhaoredhat,zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zeeke commented 2 weeks ago

/label backport-risk-assessed

openshift-ci-robot commented 2 weeks ago

@zeeke: Jira Issue OCPBUGS-43108: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43108 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017): >When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterwards, the operator webhooks returns the error: >``` >Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found >``` > >as the webhook configuration is still present, while the Service and the DaemonSet has been deleted. > >Delete all the webhook configurations when the user deletes the default SriovOperatorConfig > >4.17 backport of >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/779 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.17.0-202411080836.p0.g2d364e1.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.17.0-202411080836.p0.g2d364e1.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202411080836.p0.g2d364e1.assembly.stream.el9. All builds following this will include this PR.

zeeke commented 6 days ago

/jira backport release-4.16

openshift-ci-robot commented 6 days ago

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.16

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017#issuecomment-2485112798): >/jira backport release-4.16 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 6 days ago

@openshift-ci-robot: new pull request created: #1033

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017#issuecomment-2485113137): >@zeeke: The following backport issues have been created: >- [OCPBUGS-44727](https://issues.redhat.com//browse/OCPBUGS-44727) for branch release-4.16 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.16 > >
> >In response to [this](https://github.com/openshift/sriov-network-operator/pull/1017#issuecomment-2485112798): > >>/jira backport release-4.16 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.