search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-43361: [release-4.15] Fix operator quick restart for SNO #1020

Closed zeeke closed 3 days ago

zeeke commented 1 month ago

Backport of

zeeke commented 1 month ago

/test e2e-telco5g-sriov

zeeke commented 1 month ago

/test e2e-telco5g-sriov

zeeke commented 1 month ago

/jira cherrypick OCPBUGS-37669

openshift-ci-robot commented 1 month ago

@zeeke: Jira Issue OCPBUGS-37669 has been cloned as Jira Issue OCPBUGS-43361. Will retitle bug to link to clone. /retitle OCPBUGS-43361: [release-4.15] Fix operator quick restart for SNO

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2413804821): >/jira cherrypick OCPBUGS-37669 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@zeeke: This pull request references Jira Issue OCPBUGS-43361, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020): >Backport of >- https://github.com/openshift/sriov-network-operator/pull/1011 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-telco5g-sriov 20006a57ce8054c0da8e6445b4799be1ab01ffa4 link false /test e2e-telco5g-sriov
ci/prow/e2e-openstack-nfv 20006a57ce8054c0da8e6445b4799be1ab01ffa4 link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
wizhaoredhat commented 1 month ago

/approve

zeeke commented 1 month ago

/jira refresh /label backport-risk-assessed

@evgenLevin @ajaggapa @gregkopels can you please take a look at this backport?

openshift-ci-robot commented 1 month ago

@zeeke: This pull request references Jira Issue OCPBUGS-43361, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-37669](https://issues.redhat.com//browse/OCPBUGS-37669) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37669](https://issues.redhat.com//browse/OCPBUGS-37669) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @dgonyier

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2431142398): >/jira refresh >/label backport-risk-assessed > >@evgenLevin @ajaggapa @gregkopels can you please take a look at this backport? Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dgonyier.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2431142653): >@zeeke: This pull request references [Jira Issue OCPBUGS-43361](https://issues.redhat.com//browse/OCPBUGS-43361), which is valid. The bug has been moved to the POST state. > >
7 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.15.z) matches configured target version for branch (4.15.z) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) >* release note text is set and does not match the template >* dependent bug [Jira Issue OCPBUGS-37669](https://issues.redhat.com//browse/OCPBUGS-37669) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) >* dependent [Jira Issue OCPBUGS-37669](https://issues.redhat.com//browse/OCPBUGS-37669) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z >* bug has dependents

Requesting review from QA contact: /cc @dgonyier

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2431142398): >/jira refresh >/label backport-risk-assessed > >@evgenLevin @ajaggapa @gregkopels can you please take a look at this backport? Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

asood-rh commented 3 weeks ago

/label cherry-pick-approved

zeeke commented 2 weeks ago

@SchSeba please take a look

SchSeba commented 3 days ago

/lgtm /approve

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.15/OWNERS)~~ [SchSeba,wizhaoredhat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 days ago

@zeeke: Jira Issue OCPBUGS-43361: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43361 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020): >Backport of >- https://github.com/openshift/sriov-network-operator/pull/1011 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.15.0-202411182103.p0.g6d1554d.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.15.0-202411182103.p0.g6d1554d.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.15.0-202411182103.p0.g6d1554d.assembly.stream.el9. All builds following this will include this PR.

zeeke commented 3 days ago

/jira backport release-4.14

openshift-ci-robot commented 3 days ago

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.14

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2485075649): >/jira backport release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 3 days ago

@openshift-ci-robot: new pull request created: #1032

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2485076066): >@zeeke: The following backport issues have been created: >- [OCPBUGS-44726](https://issues.redhat.com//browse/OCPBUGS-44726) for branch release-4.14 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.14 > >
> >In response to [this](https://github.com/openshift/sriov-network-operator/pull/1020#issuecomment-2485075649): > >>/jira backport release-4.14 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.