OCPBUGS-44515: relax Operator node affinity for Hypershift

[EmilienM]

In the context of Hypershift (Hosted Clusters), where a Nodepool (terminology for a worker Node in HCP) is not a control-plane or a master Node but a worker, we can't force the

The proposal here is to relax the rule and use preferredDuringSchedulingIgnoredDuringExecution instead so the scheduler will try to find a master node or fallback on other nodes if not found.

[openshift-ci-robot]

@EmilienM: This pull request references Jira Issue OCPBUGS-44515, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1031): >In the context of Hypershift (Hosted Clusters), where a Nodepool >(terminology for a worker Node in HCP) has no access to its control >plane/masters (and doesn't even know about them), we can't force the >SR-IOV Network Operator pods to be scheduled when Nodes with >`node-role.kubernetes.io/master` and >`node-role.kubernetes.io/control-plane` are found. They don't exist in >the context of Hosted Clusters. > >The proposal here is to relax the rule and use >`preferredDuringSchedulingIgnoredDuringExecution` instead so the scheduler >will try to find a node that meets the rule but the Pods will still be >scheduled if not found. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM Once this PR has been reviewed and has the lgtm label, please assign wizhaoredhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/sriov-network-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[EmilienM]

/jira refresh

[openshift-ci-robot]

@EmilienM: This pull request references Jira Issue OCPBUGS-44515, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1031#issuecomment-2474742813): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[SchSeba]

/hold

we need to take care of this on u/s

[EmilienM]

Upstream PR: https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/806

[EmilienM]

Will be taken care of by the bot since the upstream PR just merged /close

[openshift-ci[bot]]

@EmilienM: Closed this PR.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1031#issuecomment-2488205729): >Will be taken care of by the bot since the upstream PR just merged >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-ci-robot]

@EmilienM: This pull request references Jira Issue OCPBUGS-44515. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/1031): >In the context of Hypershift (Hosted Clusters), where a Nodepool >(terminology for a worker Node in HCP) is not a control-plane or >a master Node but a worker, we can't force the > >The proposal here is to relax the rule and use >`preferredDuringSchedulingIgnoredDuringExecution` instead so the scheduler >will try to find a master node or fallback on other nodes if not found. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.