openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

d/s: remove `spec.install.spec.deployments` from base CSV #942

Closed zeeke closed 5 months ago

zeeke commented 5 months ago

File config/manager/manager.yaml defines the operator Deployment that is reported by the final ClusterServiceVersion (CSV) and overwrites whatever is written in the base CSV definition (config/manifests/bases/sriov-network-operator.clusterserviceversion.yaml). Remove the definition that is not used to make the operator's bundle build process clearer.

openshift-ci[bot] commented 5 months ago

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zeeke commented 5 months ago

@bn222 @SchSeba please take a look

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/master/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.17.0-202405311517.p0.gede1aba.assembly.stream.el9 for distgit sriov-network-operator. All builds following this will include this PR.