search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-32139,OCPBUGS-36243: Sync 2024 06 27 #945

Closed SchSeba closed 5 months ago

cgoncalves commented 5 months ago

/lgtm

SchSeba commented 5 months ago

/hold

I want @bn222 and @wizhaoredhat to approve this one

EmilienM commented 5 months ago

This is a big rebase, let's see how the openstack-nfv job works.

wizhaoredhat commented 5 months ago

LGTM @bn222 PTAL

cgoncalves commented 5 months ago

@EmilienM almost half are merge commits. Beware of two critical regressions backported to 4.14.z and that this PR includes fixes for: 1. https://issues.redhat.com/browse/OCPBUGS-32139

  1. https://issues.redhat.com/browse/OCPBUGS-36243
zeeke commented 5 months ago

/retitle OCPBUGS-32139,OCPBUGS-36243: Sync 2024 06 27

openshift-ci-robot commented 5 months ago

@SchSeba: This pull request references Jira Issue OCPBUGS-32139, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-36243, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/945): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@zeeke: This pull request references Jira Issue OCPBUGS-32139, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-36243, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/sriov-network-operator/pull/945#issuecomment-2195430826): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

@SchSeba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 69600ee4b3141327f566562904dcd358d015a5f0 link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
EmilienM commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, EmilienM, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/master/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SchSeba commented 5 months ago

/hold cancel

openshift-ci-robot commented 5 months ago

@SchSeba: Jira Issue OCPBUGS-32139: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32139 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-36243: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36243 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/945): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.