openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

NO-JIRA: Rename Dockerfile #955

Closed ashwindasr closed 2 months ago

ashwindasr commented 4 months ago

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: https://github.com/openshift/release/pull/54079 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

openshift-ci-robot commented 4 months ago

@ashwindasr: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/955): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/54079 (probably needs to merge first) > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 4 months ago

/hold

Needs to merge with an ocp-build-data PR

SchSeba commented 4 months ago

Hi @ashwindasr I am fine with the changes do you prefer to merge the release repo first?

ashwindasr commented 4 months ago

Thanks @SchSeba, yes lets get the release PR in first. Also if you can lgtm, approve to this PR as well, I can shepherd the PRs to merge

ashwindasr commented 4 months ago

also the release PR https://github.com/openshift/release/pull/54079 seems to be missing a approved label?

zeeke commented 2 months ago

Dependency PR is merged

/hold cancel /approve /lgtm /retest

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/master/OWNERS)~~ [zeeke] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.18.0-202409021542.p0.ga702ebf.assembly.stream.el9. All builds following this will include this PR.