search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-36127: Bump github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7 #960

Closed vrindle closed 3 months ago

vrindle commented 4 months ago

Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.

updated-dependencies:

wizhaoredhat commented 4 months ago

/approve

SchSeba commented 4 months ago

The CI here is not happy can you please take a look. also is it a cherry-pick from other versions? is it a cherry-pcik from the u/s repo?

vrindle commented 4 months ago

@SchSeba it is a cherry-pick from u/s. In other branches in the d/s it was included in this PR: https://github.com/openshift/sriov-network-operator/pull/954

SchSeba commented 4 months ago

right please take a look there is a problem with the go version in 4.12 with this change

/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go vet ./...
/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen "crd:crdVersions={v1}" webhook paths="./..." output:crd:artifacts:config=./config/crd/bases
cp ./config/crd/bases/* ./deployment/sriov-network-operator/crds/
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240707215[50](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_sriov-network-operator/960/pull-ci-openshift-sriov-network-operator-release-4.12-api/1810238230025474048#1:build-log.txt%3A50)1-3299760ea46c
go: downloading sigs.k8s.io/controller-runtime v0.18.4
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240707215501-3299760ea46c): go.mod:3: invalid go version '1.22.0': must match format 1.23

there is a need to fix that before we can merge

vrindle commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@vrindle: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277032544): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960): >Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.0 to 0.7.7. >- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md) >- [Commits](https://github.com/hashicorp/go-retryablehttp/compare/v0.7.0...v0.7.7) > >--- >updated-dependencies: >- dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ... Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrindle commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277035778): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yingwang-0320 commented 3 months ago

/label cherry-pick-approved

bn222 commented 3 months ago

/lgtm

bn222 commented 3 months ago

/label backport-risk-assessed

bn222 commented 3 months ago

/test ci/prow/pkg

bn222 commented 3 months ago

/test ci/prow/controllers

openshift-ci[bot] commented 3 months ago

@bn222: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277394119): >/test ci/prow/pkg Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@bn222: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277394257): >/test ci/prow/controllers Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@bn222: Overrode contexts on behalf of bn222: ci/prow/pkg

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277393806): >/override ci/prow/pkg Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vrindle commented 3 months ago

/test ci/prow/controllers

openshift-ci[bot] commented 3 months ago

@vrindle: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277589101): > >/test ci/prow/controllers > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vrindle commented 3 months ago

/test controllers

vrindle commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277590449): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vrindle commented 3 months ago

/override controllers

openshift-ci[bot] commented 3 months ago

@vrindle: vrindle unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277614587): >/override controllers Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
vrindle commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36128](https://issues.redhat.com//browse/OCPBUGS-36128) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36128](https://issues.redhat.com//browse/OCPBUGS-36128) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960#issuecomment-2277615046): > >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 6af03899cd31c9f171c20e23360852bae560bf38 and 2 for PR HEAD 4b8d48f4697c54893b36b282f9dad35e116e358e in total

vrindle commented 3 months ago

/test controllers

zeeke commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, vrindle, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.12/OWNERS)~~ [bn222,wizhaoredhat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@vrindle: Jira Issue OCPBUGS-36127: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36127 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/960): >Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.0 to 0.7.7. >- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md) >- [Commits](https://github.com/hashicorp/go-retryablehttp/compare/v0.7.0...v0.7.7) > >--- >updated-dependencies: >- dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ... Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.