Closed vrindle closed 3 months ago
/approve
The CI here is not happy can you please take a look. also is it a cherry-pick from other versions? is it a cherry-pcik from the u/s repo?
@SchSeba it is a cherry-pick from u/s. In other branches in the d/s it was included in this PR: https://github.com/openshift/sriov-network-operator/pull/954
right please take a look there is a problem with the go version in 4.12 with this change
/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go vet ./...
/go/src/github.com/openshift/sriov-network-operator/bin/controller-gen "crd:crdVersions={v1}" webhook paths="./..." output:crd:artifacts:config=./config/crd/bases
cp ./config/crd/bases/* ./deployment/sriov-network-operator/crds/
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240707215[50](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_sriov-network-operator/960/pull-ci-openshift-sriov-network-operator-release-4.12-api/1810238230025474048#1:build-log.txt%3A50)1-3299760ea46c
go: downloading sigs.k8s.io/controller-runtime v0.18.4
go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest (in sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240707215501-3299760ea46c): go.mod:3: invalid go version '1.22.0': must match format 1.23
there is a need to fix that before we can merge
/jira refresh
@vrindle: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh
.
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/label cherry-pick-approved
/lgtm
/label backport-risk-assessed
/test ci/prow/pkg
/test ci/prow/controllers
@bn222: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test api
/test ci-index-sriov-network-operator-bundle
/test controllers
/test gofmt
/test images
/test operator-e2e
/test pkg
The following commands are available to trigger optional jobs:
/test e2e-openstack-nfv
/test e2e-openstack-nfv-hwoffload
Use /test all
to run all jobs.
@bn222: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test api
/test ci-index-sriov-network-operator-bundle
/test controllers
/test gofmt
/test images
/test operator-e2e
/test pkg
The following commands are available to trigger optional jobs:
/test e2e-openstack-nfv
/test e2e-openstack-nfv-hwoffload
Use /test all
to run all jobs.
@bn222: Overrode contexts on behalf of bn222: ci/prow/pkg
/test ci/prow/controllers
@vrindle: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test api
/test ci-index-sriov-network-operator-bundle
/test controllers
/test gofmt
/test images
/test operator-e2e
/test pkg
The following commands are available to trigger optional jobs:
/test e2e-openstack-nfv
/test e2e-openstack-nfv-hwoffload
Use /test all
to run all jobs.
/test controllers
/jira refresh
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/override controllers
@vrindle: vrindle unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.
/jira refresh
@vrindle: This pull request references Jira Issue OCPBUGS-36127, which is valid.
Requesting review from QA contact: /cc @zhaozhanqi
/retest-required
Remaining retests: 0 against base HEAD 6af03899cd31c9f171c20e23360852bae560bf38 and 2 for PR HEAD 4b8d48f4697c54893b36b282f9dad35e116e358e in total
/test controllers
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bn222, vrindle, wizhaoredhat, zeeke
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@vrindle: Jira Issue OCPBUGS-36127: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-36127 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.12.0-202408091241.p0.g83b800f.assembly.stream.el8. All builds following this will include this PR.
Bumps github.com/hashicorp/go-retryablehttp from 0.7.0 to 0.7.7.
updated-dependencies: