search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
117 stars 106 forks source link

AUTH-482: set required-scc for openshift workloads #971

Closed kramaranya closed 1 month ago

kramaranya commented 1 month ago

AUTH-482

openshift-ci-robot commented 1 month ago

@kramaranya: This pull request references AUTH-482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/971): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kramaranya Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/sriov-network-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kramaranya commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@kramaranya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@kramaranya: This pull request references AUTH-482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/971): >[AUTH-482](https://issues.redhat.com/browse/AUTH-482) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
SchSeba commented 1 month ago

/hold

SchSeba commented 1 month ago

please don't change files on this repo. open the PR on the u/s repo

SchSeba commented 1 month ago

closing this one we open the change on the u/s repo

/close

openshift-ci[bot] commented 1 month ago

@SchSeba: Closed this PR.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/971#issuecomment-2262648556): >closing this one we open the change on the u/s repo > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.