search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
117 stars 106 forks source link

OCPBUGS-37668: [release-4.15] operator: LeaderElectionReleaseOnCancel #974

Closed zeeke closed 2 weeks ago

zeeke commented 1 month ago

backport of:

This ensure the lease is released by the operator as soon as it gracefully stops.

zeeke commented 1 month ago

/jira cherrypick OCPBUGS-23795

openshift-ci-robot commented 1 month ago

@zeeke: Jira Issue OCPBUGS-23795 has been cloned as Jira Issue OCPBUGS-37668. Will retitle bug to link to clone. /retitle OCPBUGS-37668: [release-4.15] operator: LeaderElectionReleaseOnCancel

In response to [this](https://github.com/openshift/sriov-network-operator/pull/974#issuecomment-2256398927): >/jira cherrypick OCPBUGS-23795 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@zeeke: This pull request references Jira Issue OCPBUGS-37668, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/974): >backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/556 > >This ensure the lease is released by the operator as soon as it gracefully stops. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zeeke commented 1 month ago

/jira backport release-4.14

openshift-ci-robot commented 1 month ago

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.14

In response to [this](https://github.com/openshift/sriov-network-operator/pull/974#issuecomment-2256422237): >/jira backport release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/974#issuecomment-2256422520): >@zeeke: The following backport issues have been created: >- [OCPBUGS-37669](https://issues.redhat.com//browse/OCPBUGS-37669) for branch release-4.14 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.14 > >
> >In response to [this](https://github.com/openshift/sriov-network-operator/pull/974#issuecomment-2256422237): > >>/jira backport release-4.14 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] commented 1 month ago

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv 20d88f4a1dc3c7a7addd763069722473d4d97299 link false /test e2e-openstack-nfv
ci/prow/e2e-openstack-nfv-hwoffload 20d88f4a1dc3c7a7addd763069722473d4d97299 link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
SchSeba commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.15/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zeeke commented 1 month ago

/hold

wait for the fix in:

openshift-ci-robot commented 2 weeks ago

@zeeke: This pull request references Jira Issue OCPBUGS-37668. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/974): >backport of: >- https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/556 > >This ensure the lease is released by the operator as soon as it gracefully stops. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.