openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
117 stars 106 forks source link

OCPBUGS-39355: release[4.16] allow to remove a sriovPool named default #994

Open SchSeba opened 3 weeks ago

SchSeba commented 3 weeks ago

we allow any name for the pool policy

SchSeba commented 3 weeks ago

/jira cherrypick OCPBUGS-37567

openshift-ci-robot commented 3 weeks ago

@SchSeba: Jira Issue OCPBUGS-37567 has been cloned as Jira Issue OCPBUGS-39355. Will retitle bug to link to clone. /retitle OCPBUGS-39355: allow to remove a sriovPool named default

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994#issuecomment-2324598685): >/jira cherrypick OCPBUGS-37567 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@SchSeba: This pull request references Jira Issue OCPBUGS-39355, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994): >we allow any name for the pool policy Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.16/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 weeks ago

@SchSeba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 16d6264d87362511c9f3f46f64c87313b83f535d link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).