search

openshift / sriov-network-operator

SR-IOV Network Operator
Apache License 2.0
119 stars 106 forks source link

OCPBUGS-39355: release[4.16] allow to remove a sriovPool named default #994

Closed SchSeba closed 1 month ago

SchSeba commented 2 months ago

we allow any name for the pool policy

SchSeba commented 2 months ago

/jira cherrypick OCPBUGS-37567

openshift-ci-robot commented 2 months ago

@SchSeba: Jira Issue OCPBUGS-37567 has been cloned as Jira Issue OCPBUGS-39355. Will retitle bug to link to clone. /retitle OCPBUGS-39355: allow to remove a sriovPool named default

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994#issuecomment-2324598685): >/jira cherrypick OCPBUGS-37567 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@SchSeba: This pull request references Jira Issue OCPBUGS-39355, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994): >we allow any name for the pool policy Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@SchSeba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-hwoffload 16d6264d87362511c9f3f46f64c87313b83f535d link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zeeke commented 1 month ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/sriov-network-operator/blob/release-4.16/OWNERS)~~ [SchSeba] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ajaggapa commented 1 month ago

/label cherry-pick-approved

cgoncalves commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@cgoncalves: This pull request references Jira Issue OCPBUGS-39355, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994#issuecomment-2396896201): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
SchSeba commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@SchSeba: This pull request references Jira Issue OCPBUGS-39355, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37567](https://issues.redhat.com//browse/OCPBUGS-37567) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37567](https://issues.redhat.com//browse/OCPBUGS-37567) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents

Requesting review from QA contact: /cc @evgenLevin

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994#issuecomment-2411029555): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
SchSeba commented 1 month ago

/override ci/prow/e2e-openstack-nfv-hwoffload

openshift-ci[bot] commented 1 month ago

@SchSeba: Overrode contexts on behalf of SchSeba: ci/prow/e2e-openstack-nfv-hwoffload

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994#issuecomment-2414551984): >/override ci/prow/e2e-openstack-nfv-hwoffload Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD f7183581e8c246f0d0b4328d1faa36a43323d90e and 2 for PR HEAD 16d6264d87362511c9f3f46f64c87313b83f535d in total

openshift-ci-robot commented 1 month ago

@SchSeba: Jira Issue OCPBUGS-39355: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39355 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/sriov-network-operator/pull/994): >we allow any name for the pool policy Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fsriov-network-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator This PR has been included in build sriov-network-operator-container-v4.16.0-202410152205.p0.g4af1a16.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon This PR has been included in build sriov-network-config-daemon-container-v4.16.0-202410152205.p0.g4af1a16.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook This PR has been included in build sriov-network-webhook-container-v4.16.0-202410152205.p0.g4af1a16.assembly.stream.el9. All builds following this will include this PR.