openshift / svt

Apache License 2.0
124 stars 105 forks source link

Update imagestreamtag of applications #691

Closed Shrivaibavi closed 3 years ago

Shrivaibavi commented 3 years ago

Updated imagestreams of few applications listed below

  1. Cakephp
  2. nodejs
  3. tomcat
  4. rails
  5. eap
  6. django
  7. dancer

Signed-off-by: Shrivaibavi Raghaventhiran sraghave@redhat.com

mffiedler commented 3 years ago

LGTM - I will test today. Thanks for the PR

mffiedler commented 3 years ago

@Shrivaibavi Looks good - one requested change to get mysql working:

Also, nodejs-mongodb and tomcat8-mongodb should be removed as mongodb no longer in OCP. I created a separate issue for that: #692. No need to address those in this PR

Shrivaibavi commented 3 years ago

@Shrivaibavi Looks good - one requested change to get mysql working:

  • Please update mysql in the cakephp and eap71 templates to :latest. In eap71 it is in the env var MYSQL_IMAGE_STREAM_TAG Comments Incorporated Also, nodejs-mongodb and tomcat8-mongodb should be removed as mongodb no longer in OCP. I created a separate issue for that: #692. No need to address those in this PR
Shrivaibavi commented 3 years ago

Comments Incorporated

Shrivaibavi commented 3 years ago

Local Run passed, Pasting the logs here http://pastebin.test.redhat.com/1002487