openshift / svt

Apache License 2.0
123 stars 105 forks source link

bad actor test case #759

Closed lenahorsley closed 1 year ago

lenahorsley commented 1 year ago

@qiliRedHat @paigerube14

lenahorsley commented 1 year ago

Test executed on CLI. Output can be found in comment section of OCPQE-14719

paigerube14 commented 1 year ago

Lena, I'm not sure what Qiujie's thoughts are on this but I think that the perfscale_regression_ci folder should be where we have re-written test cases using kube-burner to create the objects not using our own scripts or cluster-loader. Since kube-burner does not support the parallelism creation I think we should move this to one of the old folders (maybe openshift_scalability). Would be good to maybe create a folder specific to the bad actor work under openshift_scalability under scripts. I see that you are going to be adding new features so think a whole folder with this work would be good. What are your thoughts?

paigerube14 commented 1 year ago

Adding Sahil as a reviewer since he I think he had also looked into this work as well

lenahorsley commented 1 year ago

@paigerube14 Let's see what Qiujie says...

qiliRedHat commented 1 year ago

@paigerube14 @lenahorsley I agree with moving to old folders, openshift_scalability or openshift_performance.

lenahorsley commented 1 year ago

@paigerube14 @qiliRedHat @shahsahil264

lenahorsley commented 1 year ago

@paigerube14 @qiliRedHat @shahsahil264

qiliRedHat commented 1 year ago

@lenahorsley Changes looks good to me . While there are some extra spaces at the beginning of some lines, would you update and squash the commits?

openshift-ci[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.

lenahorsley commented 1 year ago

@paigerube14 @qiliRedHat @shahsahil264

lenahorsley commented 1 year ago

Closing pull request and I'll create a new one.