search

openshift / svt

Apache License 2.0
124 stars 105 forks source link

Adding toggle encryption regression script #761

Closed skordas closed 1 year ago

skordas commented 1 year ago

Based on: JIRA, Spreadsheet Positive enable test: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/regression-test/344/ Positive disable test: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/regression-test/345/

skordas commented 1 year ago

@qiliRedHat PTAL Please check jenkins job. Is it correct way to start script (using SCRIPT variable)? or better add this to TEST_CASE?

paigerube14 commented 1 year ago

@skordas I think we have so many tests that its ok to just use TEST_CASE variable. I think Qiujie started adding to script to be able to use it in the nightly long run tests and call it consistently

paigerube14 commented 1 year ago

2 general notes, I wonder if we could add this under 1 of the predefined performance, scalability? It would be nice to have some sort of readme in this folder to talk about what its doing and how to run maybe.

skordas commented 1 year ago

I stored these scripts in main ./scripts directory, because it's something different than performance or scalability. It can be used in some performance tests. Ex. Load projects with encryption on VS Load projects with encryption off.

Adding README.md under ./perfscale_regression_ci

paigerube14 commented 1 year ago

@skordas I meant a readme under encryption to tell differences in scripts and what each is doing

skordas commented 1 year ago

In this case this file is not necessary. Everything is in header of the scripts. (The same way like in the other scripts in perfscale_regression_ci

skordas commented 1 year ago

New jenkins tests after changes: Enable encryption: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/regression-test/352/ Disable encryption - FALSE POSITIVE - I set up the short time, to get timeout: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/regression-test/353/

skordas commented 1 year ago

@paigerube14 PTAL once againe

paigerube14 commented 1 year ago

/lgtm

paigerube14 commented 1 year ago

@qiliRedHat PTAL

qiliRedHat commented 1 year ago

/lgtm