search

openshift / svt

Apache License 2.0
123 stars 105 forks source link

a fix #779

Closed qiliRedHat closed 8 months ago

qiliRedHat commented 8 months ago

((retry_count++)) 's return code is 1 when retry_count is 0 initially, that caused the script to exit because it has 'set -x'. A test:

% a=0;((a++));echo $?;echo $a
1
1
% a=1;((a++));echo $?;echo $a
0
2
openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiliRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/svt/blob/master/OWNERS)~~ [qiliRedHat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

@qiliRedHat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qiliRedHat commented 8 months ago

@paigerube14 PTAL

mffiedler commented 8 months ago

/lgtm