search

openshift / svt

Apache License 2.0
123 stars 105 forks source link

regression-test-fix #788

Closed qiliRedHat closed 2 months ago

qiliRedHat commented 2 months ago

  1. I found some wrong code in https://github.com/paigerube14/svt/blob/44389c638b200dd6830d12e4ec191dac6fcd8230/perfscale_regression_ci/scripts/common.sh#L134 I dug the history, I did some wrong change in this commit https://github.com/openshift/svt/commit/0c5a04996de7a011b1247ba15654fe5929fc5d01 And that code was copied to common.sh in this PR https://github.com/openshift/svt/pull/767#issuecomment-1708886751

  2. Fixed a test case's description.

  3. Added script for test case https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-22399 (https://issues.redhat.com/browse/OCPQE-19649) Test Result(run from my mac): Passed

    django service is ready!
Deployment configs are ready!

    But I found run from Jenkins failed https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/regression-test/552

    06-27 17:46:16.472  + tee /home/jenkins/ws/workspace/ibranch-pipeline_regression-test/output.out
06-27 17:46:18.581  Disable kube-apiserver on node ip-10-0-21-88.us-east-2.compute.internal
06-27 17:46:19.677  error: unable to get namespace namespaces "aos-qe-ci" not found
06-27 17:46:21.177  kube-apiserver-ip-10-0-21-88.us-east-2.compute.internal         5/5     Running     0          7m15s   10.0.21.88    ip-10-0-21-88.us-east-2.compute.internal   <none>           <none>
openshift-ci[bot] commented 2 months ago

@qiliRedHat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qiliRedHat commented 2 months ago

@paigerube14 @skordas PTAL

skordas commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiliRedHat, skordas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/svt/blob/master/OWNERS)~~ [qiliRedHat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment