feat: add "Focus" button re-calculates correlation from current URL.

openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data

Apache License 2.0

0 stars 7 forks source link

feat: add "Focus" button re-calculates correlation from current URL. #27

Closed alanconway closed 4 months ago

alanconway commented 5 months ago

feat: add "Focus" button to re-start correlation from current URL. #27

Focus button allows two-sided navigation between panel and main console window:

Workflow:

Open panel (e.g. on an alert screen) shows data correlated to that alert.
Navigate to other console screens
- by clicking on nodes in the correlation graph
- by using any other console links
Click "Focus" to re-compute the graph, starting from resources in the current console screen.

jgbernalp commented 5 months ago

@alanconway can you attach some screenshots so @fkargbo can check from UX perspective?

/hold

PeterYurkovich commented 5 months ago

Overall looks good, just saw a few small things to clean as far as formatting and patternfly alignment goes. Pending Fodays approval of course

alanconway commented 4 months ago

Will rebase on #38 when it merges as a simpler and more stable base.

alanconway commented 4 months ago

Talked to ts so @fkargbo , he agreed that we can commit this as is and he will provide a better UI design later. Still holding, depends on #38

alanconway commented 4 months ago

/unhold @PeterYurkovich can you /lgtm this? I've discussed the UI with foday and the current UI is not what we want, but I'd like to make the functionality available while he designs something better. The final UI can be implemented as part of https://github.com/openshift/troubleshooting-panel-console-plugin/issues/40

openshift-ci[bot] commented 4 months ago

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

PeterYurkovich commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment