Closed alanconway closed 4 months ago
@fkargbo screenshots for review. based on your proposal but slightly modified to reduce wasted screen space.
radio buttons choose neighbourhood or goal query and enable setting the depth or goal class name.
@shwetaap can you take a look also & comment?
Hi @alanconway, thanks for sharing your screenshot for the expanded query details view.
It looks good to me. I've made some PatternFly-recommended adjustments that I'll share in the attached screenshot.
Adjustments:
As such, for now I think its fine to leave the validation as just disabling the buttons, but even the URL mapping to a query is starting to get to the edge of what we can hide without letting the user know what the issue is. This is not something needed for this PR, but in the future if we continue to add more complex validation checks we should add some form validation UI to show what the issue is
Agreed. For now, korrel8r itself will validate the query string and query class, and return a reasonable error message.
@fkargbo new screenshot.
@alanconway: all tests passed!
Full PR test history. Your PR dashboard.
@fkargbo new screenshot.
Looks good to me!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alanconway, PeterYurkovich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Add controls to: