openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data
Apache License 2.0
0 stars 7 forks source link

feat: Advanced query controls, fixes #40 #41

Closed alanconway closed 4 months ago

alanconway commented 4 months ago

Add controls to:

alanconway commented 4 months ago

@fkargbo screenshots for review. based on your proposal but slightly modified to reduce wasted screen space.

Initial state, average user navigates with just Focus and the graph nodes.

image

Expanded to show query details

radio buttons choose neighbourhood or goal query and enable setting the depth or goal class name.

image

alanconway commented 4 months ago

@shwetaap can you take a look also & comment?

fkargbo commented 4 months ago

Hi @alanconway, thanks for sharing your screenshot for the expanded query details view.

It looks good to me. I've made some PatternFly-recommended adjustments that I'll share in the attached screenshot.

Adjustments:

alanconway commented 4 months ago

As such, for now I think its fine to leave the validation as just disabling the buttons, but even the URL mapping to a query is starting to get to the edge of what we can hide without letting the user know what the issue is. This is not something needed for this PR, but in the future if we continue to add more complex validation checks we should add some form validation UI to show what the issue is

Agreed. For now, korrel8r itself will validate the query string and query class, and return a reasonable error message.

alanconway commented 4 months ago

@fkargbo new screenshot.

Screenshot from 2024-07-15 17-10-56

openshift-ci[bot] commented 4 months ago

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fkargbo commented 4 months ago

@fkargbo new screenshot.

Screenshot from 2024-07-15 17-10-56

Looks good to me!

PeterYurkovich commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment