openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data
Apache License 2.0
0 stars 7 forks source link

Show Inactive Nodes #47

Closed PeterYurkovich closed 3 months ago

PeterYurkovich commented 3 months ago

Resolves #39

Background

Before release-0.1 nodes on the graph were hidden if they were unable to link to an appropriate location for some reason. However this causes some charts to be split. ie. a netflow node connects 2 halves of a graph, but the netflow plugin isn't enabled. However, these nodes may link to inaccessible places or have no links at all.

Solution

This PR looks to re-add the nodes to the graph, differentiate them from valid nodes and give a brief description of the reason they are disabled. It gives 3 preset reasons for the nodes being unavailable

It also puts a length limit on error messages to prevent overflow of the error messages.

Visualization

Screenshot 2024-08-13 at 12 15 30 PM
fkargbo commented 3 months ago

I checked out some PatternFly design guidelines and found an example we could use in addition to what you already have.

For disabled nodes, we could apply some opacity to the visual styling as shown in the screenshot. disabled nodes

Here's a link to the document for you to refer to. Let me know what you think. Thanks!

https://www.sketch.com/s/caae47dd-1ee8-4cb6-a7b1-7e404e4dec46

PeterYurkovich commented 3 months ago

@fkargbo Demo of the updated UI. After looking at the patternfly css variables I saw that 30% opacity was used in other places so thats what I've used here.

https://github.com/user-attachments/assets/7dca3913-9606-443d-9a62-82313da1877b

openshift-ci[bot] commented 3 months ago

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment