fix: K8sNode conversions URL to/from query

openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data

Apache License 2.0

0 stars 7 forks source link

fix: K8sNode conversions URL to/from query #48

Closed alanconway closed 2 months ago

alanconway commented 3 months ago

Handle label search querys
Use of apiVersion strings 'group/version' vs GroupVersionKind {group, version, kind}
Unit tests for a range of querys/URLs

alanconway commented 3 months ago

/hold

hold for more testing in the browser.

alanconway commented 3 months ago

/unhold @PeterYurkovich I updated the packages and got all tests passing. Next week will do more browser testing.

alanconway commented 2 months ago

/unhold @PeterYurkovich I added the alert translations, please review.

openshift-ci[bot] commented 2 months ago

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

PeterYurkovich commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment