fix: log and netflow query-URL conversion

openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data

Apache License 2.0

0 stars 7 forks source link

fix: log and netflow query-URL conversion #53

Closed alanconway closed 1 month ago

alanconway commented 1 month ago

Netflow URL format seems to have changed, there is no longer a q= parameter.
Fixed URL encoding parameter issues.
Updated error messages to be more consistent.
Support pod aggregated log URLs.
Simplify log conversions.

NOTE: already reviewed as https://github.com/openshift/troubleshooting-panel-console-plugin/pull/50 which was closed by mistake.

PeterYurkovich commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

PeterYurkovich commented 1 month ago

/cherry-pick release-0.2

openshift-cherrypick-robot commented 1 month ago

@PeterYurkovich: new pull request created: #54

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/53#issuecomment-2305733890): >/cherry-pick release-0.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.