search

openshift / troubleshooting-panel-console-plugin

Console Plugin to add a troubleshooting side panel to display Korrel8r data
Apache License 2.0
0 stars 7 forks source link

NO-JIRA: Fix an issue which never returned a node #92

Closed PeterYurkovich closed 1 week ago

PeterYurkovich commented 1 week ago

When using an Array.forEach loop, returns in the function will only return the inner function, not the context calling forEach. This PR converts the Array.forEach into a for ... of loop so that the correctly parsed node is returned correctly.

openshift-ci-robot commented 1 week ago

@PeterYurkovich: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/92): >When using an Array.forEach loop, returns in the function will only return the inner function, not the context calling forEach. This PR converts the Array.forEach into a for ... of loop so that the correctly parsed node is returned correctly. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Ftroubleshooting-panel-console-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgbernalp commented 1 week ago

/lgtm

jgbernalp commented 1 week ago

/cherry-pick release-0.3

openshift-cherrypick-robot commented 1 week ago

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/92#issuecomment-2459606163): >/cherry-pick release-0.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/troubleshooting-panel-console-plugin/blob/main/OWNERS)~~ [PeterYurkovich,jgbernalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-cherrypick-robot commented 1 week ago

@jgbernalp: new pull request created: #94

In response to [this](https://github.com/openshift/troubleshooting-panel-console-plugin/pull/92#issuecomment-2459606163): >/cherry-pick release-0.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.