search

openshift / vagrant-openshift

Other
83 stars 117 forks source link

Allow to sync repo with detached head #487

Closed miminar closed 8 years ago

miminar commented 8 years ago

Signed-off-by: Michal Minář miminar@redhat.com

miminar commented 8 years ago

[test]

openshift-bot commented 8 years ago

Evaluated for vagrant openshift test up to 7af8044e78da0ad437d2fdcb4cf1c6c31777f109

openshift-bot commented 8 years ago

Vagrant OpenShift Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_vagrant_openshift/51/)

danmcp commented 8 years ago

@miminar It's not clear what gets you into this condition and whether we should support it.

miminar commented 8 years ago

@miminar It's not clear what gets you into this condition and whether we should support it.

@danmcp I wanted to checkout older revision of openshift/source-to-image for fork ami job. Unfortunately, there are no branches to choose from except for master. So I tried to set S2I_BRANCH to 89b96680e451c0fa438446043f967b5660942974.

This makes sync checkout master branch because git status invoked from the modified line returns:

HEAD detached at 89b9668
nothing to commit, working tree clean

which is not matched by original regexp.

danmcp commented 8 years ago

@miminar I am debating whether we want to support this or force you to use a branch.

miminar commented 8 years ago

@miminar I am debating whether we want to support this or force you to use a branch.

Since a work-around is available (fork a repo and make a branch), I'm fine with forcing to use a branch. Closing.