search

openshift / vagrant-openshift

Other
83 stars 117 forks source link

add lsof, strace, tcpdump to base deps #492

Closed jim-minter closed 8 years ago

jim-minter commented 8 years ago

@danmcp ptal

danmcp commented 8 years ago

[test]

openshift-bot commented 8 years ago

Evaluated for vagrant openshift test up to f02ce83f260f84c90356e579e3b7609465c6bdc7

danmcp commented 8 years ago

@dobbymoodge @stevekuznetsov What's going on with this: https://github.com/openshift/vagrant-openshift/pull/482/files ?

dobbymoodge commented 8 years ago

Blocked on Steve, AFAIK. I still haven't found a good fix for the bundler/vagrant weirdness.

On Tue, Oct 11, 2016 at 6:08 PM, Dan McPherson notifications@github.com wrote:

@dobbymoodge https://github.com/dobbymoodge @stevekuznetsov https://github.com/stevekuznetsov What's going on with this: https://github.com/openshift/vagrant-openshift/pull/482/files ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift/vagrant-openshift/pull/492#issuecomment-253061685, or mute the thread https://github.com/notifications/unsubscribe-auth/ABd0FI51d9rxKusTshYLK61So3JIwJKbks5qzAj0gaJpZM4KOq3W .

stevekuznetsov commented 8 years ago

I think it can merge as it is.

danmcp commented 8 years ago

@stevekuznetsov So you have given up on fixing bundle exec rake?

stevekuznetsov commented 8 years ago

fixing

It's functional either way as it's written today. When I have more bandwidth, I can look into it but as of today the only downside to implementing it that way is people lucky enough to not have the bug have to install the plugin twice. It's a cost of some fraction of a second that a user won't be likely to notice.

dobbymoodge commented 8 years ago

I think it's worth me taking a third look at in the future, but it's not worth blocking anything now.

openshift-bot commented 8 years ago

Vagrant OpenShift Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_vagrant_openshift/62/) (Base Commit: f0a5b83735acd7cf9b6e035e66f3bf816d685805)