search

openshift / vagrant-openshift

Other
83 stars 117 forks source link

add `--prune=all` to `git gc` #496

Closed dobbymoodge closed 8 years ago

dobbymoodge commented 8 years ago

git gc leaves 2 weeks of refs by default, but with a heavily-used repo that means loads of "dangling commit" messages in the git fsck output. Adding --prune=all cleans up all commits, so we should only get one or a couple of dangling commits in the output on the next run.

dobbymoodge commented 8 years ago

@danmcp [test]

openshift-bot commented 8 years ago

Evaluated for vagrant openshift test up to d1ad0f028983d632374168ba4b9402d5075a9d88

dobbymoodge commented 8 years ago

@danmcp failure looks unrelated; merge anyway?

danmcp commented 8 years ago

@dobbymoodge I am waiting for the base_ami issue to be fixed before we merge this. This one isn't blocking anything.

stevekuznetsov commented 8 years ago

This fixes the symptom, not the problem -- dangling refs aren't normal.

danmcp commented 8 years ago

@stevekuznetsov Why aren't they? It's reusing the repo. So those are the previous commits it tested on the last run.

dobbymoodge commented 8 years ago

@stevekuznetsov They are normal the way we use that repo directory in jenkins.

stevekuznetsov commented 8 years ago

So those are the previous commits it tested on the last run.

Why are they dangling? If we don't need the branch anymore, remove it. git branch -D and git reset --hard don't leave dangling commits around, whatever workflow we're using that brings us to this state smells bad.

They are normal the way we use that repo directory in jenkins.

I understand, my point is that they are not normal for a normal git user and this means our "normal" use is suspect.

openshift-bot commented 8 years ago

Vagrant OpenShift Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_vagrant_openshift/63/) (Base Commit: f0a5b83735acd7cf9b6e035e66f3bf816d685805)