Reconfigure Docker thin-pool setup to use `docker-storage-setup`

stevekuznetsov commented 7 years ago

Instead of configuring the logical volumes by hand, we should now use the docker-storage-setup tool instead. The manual process is no longer honored by Docker 1.12.6+. The ratio of data to metadata in the logical volume is not identical to the ratio previously, but no compelling reasons are known for which the default from docker-storage-setup would be inappropriate.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

stevekuznetsov commented 7 years ago

[test]

@bparees @danmcp FYI

stevekuznetsov commented 7 years ago

@sdodson updated

stevekuznetsov commented 7 years ago

@dobbymoodge do you know why Rosie marks this as failed before it even starts the run?

dobbymoodge commented 7 years ago

@stevekuznetsov not sure, will be a bit before I can take a close look at it...

stevekuznetsov commented 7 years ago

@csrwng I am fairly sure about this impl -- when looking please keep in mind that the ordering between the OpenShift XFS stuff and the docker-storage-setup is important. We can use [test] to try to verify but manual testing will also be needed.

openshift-bot commented 7 years ago

Evaluated for vagrant openshift test up to 31afc8cd3a74918c30346602b94aa17343774fb7

openshift-bot commented 7 years ago

Vagrant OpenShift Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_vagrant_openshift/90/) (Base Commit: de6d6409a9f95d6131768f202c29d6031b2b0112)

csrwng commented 7 years ago

Two failures about branch name required:

[INFO] Testing `vagrant origin-local-checkout --replace`
Waiting for the cloning process to finish
Checking repo integrity for /data/src/github.com/openshift/origin
/data/src/github.com/openshift/origin /data/src/github.com/openshift
/data/src/github.com/openshift
Replacing: /data/src/github.com/openshift/origin
/data/src/github.com/openshift/origin /data/src/github.com/openshift
Already on 'master'
HEAD is now at cf7e336 Merge pull request #12996 from smarterclayton/local_template
fatal: branch name required
/data/src/github.com/openshift
Checking repo integrity for /data/src/github.com/openshift/source-to-image
/data/src/github.com/openshift/source-to-image /data/src/github.com/openshift
/data/src/github.com/openshift
Replacing: /data/src/github.com/openshift/source-to-image
/data/src/github.com/openshift/source-to-image /data/src/github.com/openshift
Already on 'master'
HEAD is now at cad7480 Merge pull request #690 from lholmquist/onbuild-readme-link-update
fatal: branch name required
/data/src/github.com/openshift
Checking repo integrity for /data/src/github.com/openshift/origin-web-console
/data/src/github.com/openshift/origin-web-console /data/src/github.com/openshift
/data/src/github.com/openshift
Replacing: /data/src/github.com/openshift/origin-web-console
/data/src/github.com/openshift/origin-web-console /data/src/github.com/openshift
Already on 'master'
HEAD is now at e56ff68 Merge pull request #1195 from rhamilto/run-on-e2e
Removing .tmp/
Removing bower_components/
Removing node_modules/
Removing openshift-jvm/
Removing test/coverage/
fatal: branch name required

stevekuznetsov commented 7 years ago

Re: fatal: branch name required ... @dobbymoodge is that your stuff?

csrwng commented 7 years ago

Closing this PR in favor of #534

openshift / vagrant-openshift

Reconfigure Docker thin-pool setup to use `docker-storage-setup` #532