search

openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

OCPQE-21298: Update machineset name with infrastructureName #3605

Closed sunzhaohua2 closed 5 months ago

sunzhaohua2 commented 5 months ago

As IBMCloud/gcp will not delete the resources that prefix is not infrastructureName, so if the cases were interrupted due to some reason like timeout, the resources will not be removed automatically when destroy cluster. This will update all machineset name prefix with infrastructureName. cc @MayXuQQ @huali9 @miyadav @shellyyang1989 PTAL

OCP-25436 https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/Runner/964372/console

openshift-ci-robot commented 5 months ago

@sunzhaohua2: This pull request references OCPQE-21298 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/verification-tests/pull/3605): >As IBMCloud/gcp will not delete the resources that prefix is not infrastructureName, so if the cases were interrupted due to some reason like timeout, the resources will not be removed automatically when destroy cluster. This will update all machineset name prefix with infrastructureName. cc @MayXuQQ >@huali9 @miyadav @shellyyang1989 PTAL > > OCP-25436 https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/Runner/964372/console Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fverification-tests). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
huali9 commented 5 months ago

/lgtm

liangxia commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huali9, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[features/machine/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/machine/OWNERS)~~ [liangxia] - ~~[features/networking/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/networking/OWNERS)~~ [liangxia] - ~~[features/upgrade/machines/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/upgrade/machines/OWNERS)~~ [liangxia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@sunzhaohua2: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).