openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

OCPQE-18518: Fix OCP-22018 flake on external #3608

Closed Phaow closed 5 months ago

Phaow commented 5 months ago

Add check default sc exist util

Flake record

Message: failed OCP-22018:Storage Admin can change default storage class to non-default
Type: failed

Text:

    Scenario: OCP-22018:Storage Admin can change default storage class to non-default

And the output should contain 1 times:

Message:

$ omc get sc
No resources storageclasses.storage.k8s.io found in default namespace. 

Root cause

Fix solution

Test record Runner-v3-smoke/7520/console

1 scenario (1 skipped)
5 steps (5 skipped)
0m10.993s
openshift-ci-robot commented 5 months ago

@Phaow: This pull request references OCPQE-18518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/verification-tests/pull/3608): >### Add check default sc exist util > >[Flake record](https://reportportal-openshift.apps.ocp-c1.prod.psi.redhat.com/ui/#prow/launches/1198/485118?item0Params=filter.eq.hasStats%3Dtrue%26filter.eq.hasChildren%3Dfalse%26filter.in.type%3DSTEP%26launchesLimit%3D1000%26isLatest%3Dfalse%26filter.in.status%3DFAILED%252CINTERRUPTED%26page.page%3D1%26filter.in.issueType%3Dti001%252Cti_1hrghcxlbgshc%252Cti_s4scyws6guht%252Cti_sok676b1k8j5%252Cti_r1ifkmkw19o1%26filter.cnt.name%3D%253AStorage) > >```console >Message: failed OCP-22018:Storage Admin can change default storage class to non-default >Type: failed > >Text: > > Scenario: OCP-22018:Storage Admin can change default storage class to non-default > >And the output should contain 1 times: > >Message: > > > >$ omc get sc >No resources storageclasses.storage.k8s.io found in default namespace. >``` > >**Root cause** >- Most external platform profiles does not have storageclass in the test cluster > >**Fix solution** >- Add check default sc exist util for skip no default sc exist test clusters > >**Test record** >`Runner-v3-smoke/7520/console` >```console >1 scenario (1 skipped) >5 steps (5 skipped) >0m10.993s >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fverification-tests). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Phaow commented 5 months ago

@duanwei33 @ropatil010 Could you please take a look when you get a chance? Thanks! cc to @chao007 @radeore /assign @duanwei33 @ropatil010

ropatil010 commented 5 months ago

/lgtm Thanks.!

duanwei33 commented 5 months ago

/lgtm Thanks for the update.

pruan-rht commented 5 months ago

/lgtm /approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanwei33, pruan-rht, ropatil010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/verification-tests/blob/master/OWNERS)~~ [pruan-rht] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@Phaow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).