search

openshift / verification-tests

Blackbox test suite for OpenShift.
GNU General Public License v3.0
52 stars 170 forks source link

remove the step for deployment failure #3621

Closed zhouying7780 closed 2 months ago

zhouying7780 commented 5 months ago

to debug https://issues.redhat.com/browse/OCPQE-3204 ; @kasturinarra Please help review , thanks

kasturinarra commented 4 months ago

/lgtm

kasturinarra commented 4 months ago

@liangxia could you please help review and approve

liangxia commented 4 months ago

The change will add a lot of logs in our CI, both in Prow CI and Jenkins CI. Perhaps we can add those debug steps in the test case/scenario level ?

openshift-ci[bot] commented 2 months ago

@zhouying7780: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kasturinarra commented 2 months ago

@zhouying7780 could you help me understand where you are adding the debug here ?

zhouying7780 commented 2 months ago

@kasturinarra The case always failed with pod not running , actually we don't need to check the pod status , just check the probe correct is okay . so removed some steps.

zhouying7780 commented 2 months ago

@kasturinarra At beginning I added the logs step, but liang said this will add a lot of logging , so remove it

kasturinarra commented 2 months ago

@zhouying7780 got it, thanks !!

kasturinarra commented 2 months ago

/lgtm

kasturinarra commented 2 months ago

@liangxia could you please help review and approve ? thanks !!

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[features/cli/OWNERS](https://github.com/openshift/verification-tests/blob/master/features/cli/OWNERS)~~ [kasturinarra] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment